refactor(nvim): static preview titles and delta preview fixes#93
Merged
Conversation
Reference rows are now highlighted inside delta location previews, so path:line in the preview border was redundant. Remove dynamic_preview_title and the dyn_title helpers; keep static Location/Grep Preview titles. Verify: grr on a changed file — preview title stays fixed while the reference line remains highlighted in the diff body.
Workspace symbol filtering could hit E474 when falling back from a delta terminal preview to a normal file buffer while the delta job was still running. Track preview jobs, wait for render before declaring a line missing, and jobstop before clearing buftype. Verify: gW, type in the filter on symbols in changed files — no preview errors and file-at-line fallback still works.
aguil
force-pushed
the
refactor/nvim-static-preview-title
branch
from
dce053f to
23546b7
Compare
aguil
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two related Telescope location-preview improvements:
path:lineborder titles were redundant.E474when filtering workspace symbols while a delta preview job is still running.Commits
dynamic_preview_titleanddyn_titlehelpers; keep static Location/Grep Preview titles.jobstopbefore clearingbuftype.Test plan
chezmoi applyand restart Neovimgrron a changed file: preview title stays fixed, reference row highlighted in diff bodygW(workspace symbols): type in the filter — no preview errors; file-at-line fallback works when symbol line is outside diff hunks