fix(ocp_console_embed): fix router rollout wait failing on transient API errors#69
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the IngressController patch triggers a router rolling update,
k8s_infocan temporarily fail (connection refused/timeout) because the router pods themselves serve cluster ingress. The failed result dict lacks a.resourcesattribute, causing theuntilcondition evaluation to error out and kill the retry loop instead of retrying.Changes
r_router_rollout is not failedas the firstuntilcondition inwait-router-rollout.yml, so Ansible short-circuits and retries instead of crashing on a missing.resourcesattribute whenk8s_inforeturns a failure dict.