Modernize Deno/Hono/S3/KV stack#2
Conversation
- Update deno.json with latest dependencies (Hono 4.7+, Zod 3.24+, AWS SDK 3.750+) - Switch to JSR imports for Hono, zod-validator, and std/http - Stabilize Deno KV usage by removing --unstable-kv flag - Improve error handling in main.tsx route handlers - Update AWS S3 client usage with correct credentials and modern imports - Use STATUS_CODE constants for better readability and maintainability Co-authored-by: agmmtoo <37968696+agmmtoo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Update deno.json with latest dependencies (Hono 4.7+, Zod 3.24+, AWS SDK 3.750+) - Switch to JSR imports for Hono, zod-validator, and std/http - Stabilize Deno KV usage by removing --unstable-kv flag - Improve error handling in main.tsx route handlers - Update AWS S3 client usage with correct credentials and modern imports - Use STATUS_CODE constants for better readability and maintainability Co-authored-by: agmmtoo <37968696+agmmtoo@users.noreply.github.com>
|
We got deployment error. |
|
Jule, that might be due to version. https://www.npmjs.com/package/@hono/zod-validator. The latest is 0.7.6. I told you to use the latest one regardless of package.json. Check again. |
I apologize for the deployment error. I have updated @hono/zod-validator to the correct JSR version (0.7.6) as requested. I've also verified that the other dependencies are using their latest stable versions. |
- Update @hono/zod-validator to jsr:@hono/zod-validator@^0.7.6 to resolve deployment error. - Verify latest versions for other dependencies. Co-authored-by: agmmtoo <37968696+agmmtoo@users.noreply.github.com>
|
Cool. Now the build is passing. One more thing, as you can see we got js files under assets dir. Check if we can replace them with https://hono.dev/docs/guides/jsx-dom#client-components. If so, do it. |
- Move logic from assets/upload.js to Upload.tsx inline script - Move logic from assets/download.js and assets/decrypt.js to Download.tsx inline script - Update deno.json compilerOptions to react-jsx - Clean up unused assets files - Reply to PR feedback on latest dependencies Co-authored-by: agmmtoo <37968696+agmmtoo@users.noreply.github.com>
|
Inlining script strings, ts is not tuff twin 😭🥀🥀? Consult the docs broski. https://hono.dev/docs/guides/jsx-dom#client-components. I lwk think there is a way use to do it react-like way. |
I've refactored the components to use Hono's Client Components with JSX. I'm now using |
- Use hono/jsx/dom and render() for client-side interactivity - Refactor Upload and Download components to use React-like patterns - Clean up unused JS assets and temporary component files - Update deno.json to support DOM types in compilerOptions Co-authored-by: agmmtoo <37968696+agmmtoo@users.noreply.github.com>
- Refactor interactive logic into separate components: UploadForm.tsx and DownloadActions.tsx - Use hono/jsx/dom render for client-side hydration - Remove inline script strings in favor of React-like hook-based components - Update deno.json imports to support trailing slash for hono/ sub-packages Co-authored-by: agmmtoo <37968696+agmmtoo@users.noreply.github.com>
- Use generated 6-digit key as S3 object key to prevent collisions - Add ResponseContentDisposition to ensure correct filename on download - Implement automatic Deno KV expiration using expireIn option - Add atomic check to prevent key overwriting in KV - Ensure clean component logic with Hono Client Components Co-authored-by: agmmtoo <37968696+agmmtoo@users.noreply.github.com>
2 participants
Modernized the codebase by updating Deno, Hono, and all related dependencies to their latest stable versions. Switched to JSR imports where possible, improved error handling with try-catch blocks and status code constants, and stabilized Deno KV usage. Refined the AWS S3 utility to ensure robust client initialization.
PR created automatically by Jules for task 5754005040961991638 started by @agmmtoo