Use go generate to rebuild .proto files#174
Open
burdges wants to merge 5 commits into
Open
Conversation
…protobuf. Avoids screwing around with directories or editing files now. Find gogoprotobuf at https://code.google.com/p/gogoprotobuf/
Run "go generate" in ./client, ./proto, ./panda, or ./server to recompile the associated .proto files using an appropraite protoc command. We use gogoprotobuf from https://code.google.com/p/gogoprotobuf/ because Francesc @campoy indicated that even Google uses it to goprotobuf. We previously needed a perl script to fix a path mess created by goprotobuf 29d5f5d ala protoc --proto_path=$GOPATH/src:. --go_out=. disk/client.proto perl -p -i~ -e 's/(import protos \"github.com\/agl\/pond\/protos)\/pond.pb\"/$1\"/' disk/client.pb.go
We nolonger need these scripts since go generate with gogoprotobuf is cleaner.
I recommend that @agl replace this commit by installing gogoprotobuf and running go generate in .clinet, ./protos, ./panda, ./server himself rather than reviewing it.
Contributor
Author
|
Appears relevant : https://github.com/ricochet-im/ricochet/blob/master/protobuf.pri |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We replace the shell scripts added in #161 to run protoc with go generate directives. I'd recommend that @agl rerun go generate himself rather than simply accepting e79daf2 of course.
I'll submit other pull requests that depend upon this one. Any pull request submitted by an Apple user should depend on 92157bb btw.