bshow next transaction time when sending message#127
Open
duy wants to merge 1 commit into
Open
Conversation
Contributor
duy
commented
Sep 26, 2014
duy
commented
- add nextTransactionTime variable to the client to store the next transaction absolute time
- show when next transaction will happen in the "Created new outbox..." message
- remove second decimals from "Next network transaction..." log message
* add nextTransactionTime variable to the client to store the next transaction absolute time * show when next transaction will happen in the "Created new outbox..." message * remove second decimals from "Next network transaction..." log message
Contributor
|
I suspect this patch does not provide the information intended : Pond's next transaction might not send the message you've just "sent" either because you've multiple messages in the queue already or (I think) even because your next transaction is a fetch not a send. In principle, you could reasonably display this time if (a) no messages are currently in the queue and (b) the next transaction would be a send. If (a) fails, maybe you'd want to say how many messages are ahead of it in the queue. If only (b) fails, then maybe you'd want to say "approximately" nextTransactionTime + 5min. I donno if @agl had other concerns with this patch besides those. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.