Skip to content

fix(dashboard): post-merge fixes - quick-start, worker creds, check_skip - #1081

Open
nillikechatchat wants to merge 3 commits into
agentscope-ai:mainfrom
nillikechatchat:feat/dashboard-post-merge-fixes
Open

fix(dashboard): post-merge fixes - quick-start, worker creds, check_skip#1081
nillikechatchat wants to merge 3 commits into
agentscope-ai:mainfrom
nillikechatchat:feat/dashboard-post-merge-fixes

Conversation

@nillikechatchat

Copy link
Copy Markdown
Contributor

Summary

Follow-up to PR #1075 (merged). Contains improvements that were in-flight when the original PR was merged.

Closes #1080 (continued)

Improvements (synced from codex review)

  1. Quick-start mode support: step_dashboard now handles AGENTTEAMS_QUICKSTART (aligns with main installer)
  2. Worker credential extraction: extract worker passwords/room IDs from workers-registry.json during upgrade
  3. Dashboard data volume cleanup: remove agentteams-dashboard-data volume on uninstall
  4. Gateway URL probing: probe from inside controller container (same network as dashboard) with host fallback
  5. verify.sh improvements: add check_skip() for semantically correct skip reporting; use grep -qx for exact container name matching
  6. Test 19: executable test for quick-start step_dashboard

Bug fixes

  1. 🔴 check_skip undefined: verify.sh called check_skip but never defined it — added function definition
  2. Keep-all branch preserved: codex had removed the UPGRADE_KEEP_ALL early-return in step_dashboard; restored it since maintainers explicitly require keep-all upgrade to preserve dashboard config

Test coverage

Test plan

  • bash install/agentteams-dashboard-tests.sh — 47/47 passed
  • Cross-repo consistency verified (install.sh / verify.sh / tests identical between AgentTeams and agentteams-dashboard repos)
  • bash -n syntax check passed for all modified scripts

Super User added 2 commits July 26, 2026 20:19
Sync codex improvements and fix two issues found during review:

Improvements (from codex):
- Add AGENTTEAMS_QUICKSTART support in step_dashboard (aligns with
  AgentTeams main installer's quick-start mode)
- Extract worker passwords/room IDs from workers-registry.json during
  upgrade credential extraction
- Clean up agentteams-dashboard-data volume on uninstall
- Probe gateway URL from inside controller container (same network as
  dashboard) with host fallback
- Add check_skip() to verify.sh for semantically correct skip reporting
- Use grep -qx for exact container name matching in verify.sh
- Improve env file parsing (cut -d= -f2- | tr -d '\r') in verify.sh
- Add Test 19 for quick-start step_dashboard execution

Fixes:
- Define missing check_skip() function in verify.sh (was used but
  never defined, causing 'command not found' at runtime)
- Revert version-number normalization (strip-v) in dashboard.sh/ps1
  to maintain consistency with install.sh (which expects v-prefixed
  versions). The strip-v logic was incomplete (not synced to
  install.sh) and not requested by maintainers.

Test coverage: 47/47 passed (was 44/44).
- Update verify.sh comment to reflect 7 checks (was 6, dashboard check added)
- Add curl/sleep mock to Test 18 to avoid polling real ports for 60s
- Sync test file with dashboard repo for cross-repo consistency
@nillikechatchat

nillikechatchat commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

@shiyiyue1102 这是 PR #1075 合并后的跟进 PR,包含合并时正在进行中的改进和修复。

背景

PR #1075 在第五轮审查修复(提交 21d809c)后合并。但合并时有一批改进正在同步中(提交 d720430),未能包含在合并中。本 PR 补齐这些改动。

改动内容

改进(来自 codex 审查):

  1. Quick-start 模式支持(AGENTTEAMS_QUICKSTART
  2. Worker 凭证提取(升级时从 workers-registry.json 提取)
  3. Dashboard 数据卷清理(卸载时清理 agentteams-dashboard-data
  4. 网关 URL 探测改进(从控制器内部探测,主机兜底)
  5. verify.sh 新增 check_skip() 语义化跳过
  6. 新增 Test 19(quick-start 执行测试)

修复

  1. 🔴 check_skip 函数未定义(verify.sh 调用但从未定义,运行时报错)
  2. 恢复 keep-all 分支(codex 误删,维护者要求保留)

测试

请您审阅,感谢!


@shiyiyue1102 This is a follow-up PR after the merge of PR #1075, containing improvements and fixes that were in progress at the time of the merge.

Background

PR #1075 was merged after the fifth round of review fixes (commit 21d809c). However, a batch of improvements were being synchronized during the merge (commit d720430) and were not included in the merge. This PR addresses these changes.

Change content

Improvements (from codex review):

  1. Quick-start mode support (AGENTTEAMS_QUICKSTART)
  2. Worker credentials extraction (extracted from workers-registry.json when upgrading)
  3. Dashboard data volume cleanup (clean up agentteams-dashboard-data when uninstalling)
  4. Improved gateway URL detection (detection from inside the controller, the host knows everything)
  5. verify.sh adds check_skip() to semantically skip
  6. Added Test 19 (quick-start execution test)

Fix:

  1. 🔴 check_skip function is not defined (verify.sh is called but never defined, and an error occurs when running)
  2. Restore the keep-all branch (codex was accidentally deleted and the maintainer requested to keep it)

Test

Please review, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Integrate agentteams-dashboard as optional management UI

1 participant