Skip to content

fix(test): target Manager agent for MCP checks - #1036

Open
RerankerGuo wants to merge 1 commit into
agentscope-ai:mainfrom
RerankerGuo:fix/test12-manager-agent-container
Open

fix(test): target Manager agent for MCP checks#1036
RerankerGuo wants to merge 1 commit into
agentscope-ai:mainfrom
RerankerGuo:fix/test12-manager-agent-container

Conversation

@RerankerGuo

Copy link
Copy Markdown
Contributor

Summary

In the embedded architecture, TEST_CONTROLLER_CONTAINER names the infrastructure/controller container while TEST_AGENT_CONTAINER names the Manager Agent container. Test 12 still used the controller variable for all mcporter commands, so the GitHub MCP checks ran in a container without the Manager workspace or MCP configuration.

Prefer TEST_AGENT_CONTAINER, retain the controller fallback for legacy all-in-one deployments, and use the current Manager name as the final fallback.

Verification

  • recording Docker stub before the fix: all 18 mcporter calls targeted agentteams-controller
  • recording Docker stub after the fix: all 18 calls target agentteams-manager
  • bash -n tests/test-12-github-mcp-tools.sh
  • git diff --check

@github-actions

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (controller-cr-2 / mgr=copaw / wk=copaw)

Commit: ba16f9f
Workflow run: #1663

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@github-actions

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (llm-interaction-2 / mgr=copaw / wk=hermes)

Commit: ba16f9f
Workflow run: #1663

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@github-actions

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (llm-interaction / mgr=copaw / wk=hermes)

Commit: ba16f9f
Workflow run: #1663

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@github-actions

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (llm-interaction-2 / mgr=copaw / wk=copaw)

Commit: ba16f9f
Workflow run: #1663

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@github-actions

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (controller-cr / mgr=copaw / wk=copaw)

Commit: ba16f9f
Workflow run: #1663

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@github-actions

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (llm-interaction / mgr=openclaw / wk=openclaw)

Commit: ba16f9f
Workflow run: #1663

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@github-actions

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (controller-cr / mgr=openclaw / wk=openclaw)

Commit: ba16f9f
Workflow run: #1663

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@github-actions

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (llm-interaction / mgr=copaw / wk=copaw)

Commit: ba16f9f
Workflow run: #1663

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@github-actions

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (controller-cr / mgr=copaw / wk=hermes)

Commit: ba16f9f
Workflow run: #1663

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@github-actions

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (llm-interaction-2 / mgr=openclaw / wk=openclaw)

Commit: ba16f9f
Workflow run: #1663

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@RerankerGuo

Copy link
Copy Markdown
Contributor Author

CI attribution: all 9 translation/base/image checks passed for ba16f9f. I inspected the raw logs for all 10 failed matrix jobs in run #1663; each log has an empty AGENTTEAMS_LLM_API_KEY, exits from install-embedded with code 2 and LLM API Key is required, and reports no test output. The workflow therefore never reached test 12. This is the same pull_request_target base-workflow secret blocker addressed by #1026, so the locally verified Manager-container fix is unchanged.

@shiyiyue1102

Copy link
Copy Markdown
Collaborator

This two-line test correction is reasonable, but it has little standalone value. There is a larger group of tiny rename/test-contract PRs here (#1033, #1034, #1035, #1030, #1028, and nearby dev-helper fixes). Please consolidate the related corrections into one focused test-contract cleanup and list the exact failing tests each change fixes. That will let us validate and merge the rename fallout as one coherent unit instead of reviewing many two-to-eight-line PRs separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants