fix(make): target AgentTeams containers in dev utils - #1029
Open
RerankerGuo wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
CI note: all 9 build/translation checks passed on run #1657. I inspected the raw logs for all 10 failed integration matrix jobs; every job stopped before tests during embedded install with the identical |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make statuslist the renamedagentteams-*containersmake cleanremoveagentteams-test-worker-*containers created by the current test harnessRoot cause
The AgentTeams contract rename updated the container names and most Makefile targets, but these two Docker name filters still used the old
hiclaw-*prefixes. As a result,make statusomitted current containers andmake cleanleft current test workers behind.Validation
make statusagainst a recording Docker stub and verified thename=agentteams-filter plus controller/manager outputmake clean TEST_CONTAINER=agentteams-manager-testagainst the stub and verified both current test workers were removedmake -n statusandmake -n clean TEST_CONTAINER=agentteams-manager-testgit diff --check