fix(agent): guard team creation against duplicate relationship replies - #1010
Open
RerankerGuo wants to merge 3 commits into
Open
fix(agent): guard team creation against duplicate relationship replies#1010RerankerGuo wants to merge 3 commits into
RerankerGuo wants to merge 3 commits into
Conversation
Contributor
📊 CI Metrics ReportSummary
By Role
Per-Test Breakdown
Trends✅ 1 test(s) improved (fewer LLM calls) Generated by HiClaw CI on 2026-07-13 14:38:05 UTC |
RerankerGuo
marked this pull request as ready for review
July 9, 2026 14:26
RerankerGuo
force-pushed
the
fix/issue-987-team-create-idempotency-clean
branch
from
July 10, 2026 02:16
5231bf0 to
0b4a89c
Compare
RerankerGuo
force-pushed
the
fix/issue-987-team-create-idempotency-clean
branch
from
July 13, 2026 13:20
0b4a89c to
607e232
Compare
RerankerGuo
force-pushed
the
fix/issue-987-team-create-idempotency-clean
branch
from
July 13, 2026 13:32
607e232 to
1977bb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hiclaw get team <TEAM_NAME> -o jsonbeforehiclaw create team.Why
Fixes #987. The reported flow asks the Manager to explain an existing Team, Leader DM, and Worker relationship, but the Manager can interpret that as another team creation request. The new guidance makes relationship explanation read-only and makes duplicate creation checks explicit.
Temporary dependencies
This branch is temporarily stacked on #985 and #1015. Its previous CI failure
was SHARD_D/test-21: the Leader kept working in its DM instead of coordinating
in the Team Room. #1015 fixes that behavior and now passes all 10 integration
matrix jobs; #1015 itself uses #985 for deterministic SHARD_A setup.
Relative to #1015, this PR still changes only:
changelog/current.mdmanager/agent/skills/team-management/SKILL.mdmanager/agent/skills/team-management/references/create-team.mdAfter the dependency PRs merge, this PR automatically reduces to those files.
Validation
git diff --checkagainst test: nudge team leader to coordinate in team room #1015Service Unavailablewhile resolving action metadataLocal runtime reproduction was not run because this is an agent-facing built-in instruction change and the local Docker socket is not accessible in this environment.