keep tool results - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes the
pi --mode jsonoutput contract by emitting completed assistant messages andtoolResultmessages, which may break consumers that relied on the previous assistant-only/turn-end behavior.Overview
pi --mode jsonnow outputs a compact JSONL transcript of completed messages, emittingmessage_endrecords foruser,assistant, andtoolResultroles (instead of relying onturn_endfor assistant turns).Docs and changelog are updated to describe the new transcript semantics (assistant message that requested a tool followed by a
toolResult), and tests are adjusted to assert the new ordering and inclusion of tool results.Reviewed by Cursor Bugbot for commit e44041c. Bugbot is set up for automated code reviews on this repo. Configure here.