agw-standalone feedback: security/http-authz - clarify require and ...#558
Open
artberger wants to merge 2 commits into
Open
agw-standalone feedback: security/http-authz - clarify require and ...#558artberger wants to merge 2 commits into
artberger wants to merge 2 commits into
Conversation
Deploying agentproxy with
|
| Latest commit: |
40d99d0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://02607cf7.agentproxy.pages.dev |
| Branch Preview URL: | https://issue-2433.agentproxy.pages.dev |
artberger
commented
Jun 3, 2026
artberger
commented
Jun 3, 2026
artberger
commented
Jun 3, 2026
artberger
commented
Jun 3, 2026
…docs Rewrite the rule evaluation list to accurately describe the denylist/allowlist fallback in terms of whether allow rules are configured (not "only deny rules exist"), which correctly accounts for require rules. Add a warning callout documenting CEL evaluation error behavior: require is fail-closed, deny is fail-open. Correct the misleading claim that require and deny rules are "equivalent" — they differ when the CEL expression errors. Signed-off-by: Art Berger <art.berger@solo.io>
Co-authored-by: Art <artberger@users.noreply.github.com> Signed-off-by: Art Berger <art.berger@solo.io>
| ``` | ||
|
|
||
| Unlike `allow` rules, all `require` rules must match for the request to proceed. Use `require` rules to express invariants like "all requests must have a valid audience claim." No newline at end of file | ||
| These behave the same when a JWT with an audience claim is present, but they differ when the claim is missing. With no JWT, `jwt.aud` is undefined and both expressions error: |
Collaborator
There was a problem hiding this comment.
Suggested change
| These behave the same when a JWT with an audience claim is present, but they differ when the claim is missing. With no JWT, `jwt.aud` is undefined and both expressions error: | |
| These rules behave the same when a JWT with an audience claim is present, but they differ when the claim is missing. With no JWT, `jwt.aud` is undefined and both expressions error: |
kristin-kronstain-brown
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Single-package documentation correction to the HTTP authorization page, applied identically to both the
latest(v1.2.x) andmaindoc branches.Closes #2433