-
Notifications
You must be signed in to change notification settings - Fork 0
Add held agent-facets CLI release gate for supplementary-file activation #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
eXamadeus
merged 1 commit into
main
from
julian/07-24-activate-supplementary-files-changeset
Jul 24, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| --- | ||
| 'agent-facets': minor | ||
| --- | ||
|
|
||
| **BREAKING (pre-1.0 minor):** activate supplementary-file support, archive and lockfile format `0.2`, and adapter API `0.1`. | ||
|
|
||
| Every `facet build` now emits `facetVersion: 0.2` with a complete per-entry hash map. Facets can explicitly declare opaque supplementary files: skill companions install and remove atomically with their owning skill, while root and other archive-only files remain integrity-protected without being materialized. Valid legacy `0.1` archives remain installable during the compatibility window. | ||
|
|
||
| Current lockfiles and machine-local receipts use format `0.2` with canonical per-file integrity and ownership records, enabling exact-path drift reporting, repair, rollback, and offline removal without deleting unowned files. | ||
|
|
||
| `facet create` writes and declares an editable `README.md` by default, with `--no-readme` as the headless opt-out. `facet edit` manages both `README.md` and the extensionless `README` and reconciles supplementary declarations transactionally. | ||
|
|
||
| New manifests require single-segment Agent Skills names, and skills and commands cannot share a name. Existing published `0.1` archives retain legacy naming behavior, but affected source manifests must be renamed before rebuilding as `0.2`. | ||
|
|
||
| This CLI supports only the tagged adapter API `0.1`. Positional `0.0` adapters fail closed before contract calls or project mutation with reinstall guidance. Rebuild custom adapters against the current `@agent-facets/adapter` SDK and reinstall incompatible adapters before continuing. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description states "Projected release:
agent-facets@0.31.0", but the changeset here is a singleminorbump on top of the currentagent-facets@0.28.0baseline, which yields0.29.0. This was already corrected onmainvia #465 (df33bee), which updatedMINIMUM_RELEASE_FOR_FORMAT['0.2']from0.31.0to0.29.0precisely because the activation version is0.29.0. The PR description wasn't updated to match — anyone reading the merge conditions will see the wrong version. Worth updating the description toagent-facets@0.29.0before this leaves draft so the authorization language is accurate.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!