Add in design theme by eXamadeus · Pull Request #357 · agent-facets/facets

eXamadeus · 2026-06-23T19:17:32Z

Why

Details

Verification

Summary by CodeRabbit

New Features
- Brand navigation now points to theme-specific design documentation based on the current theme (desktop).
- Design-system HTML is bundled as separate light/dark pages for production and available directly during development.
Chores
- Updated formatting/lint pre-commit checks to ignore design documentation assets.
- Added build-time app version injection for landing builds.

changeset-bot · 2026-06-23T19:17:38Z

⚠️ No Changeset found

Latest commit: 4822cae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

eXamadeus · 2026-06-23T19:17:47Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

coderabbitai · 2026-06-23T19:17:51Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d940eaa0-a7ef-44e9-8dbf-15309ec47eb3

📥 Commits

Reviewing files that changed from the base of the PR and between 9748a21 and 4822cae.

📒 Files selected for processing (7)

biome.json
lefthook.yml
packages/landing/design-dark.html
packages/landing/design-light.html
packages/landing/src/components/Nav.tsx
packages/landing/vite.config.ts
packages/landing/vite/design-system-plugin.ts

✅ Files skipped from review due to trivial changes (2)

biome.json
lefthook.yml

🚧 Files skipped from review as they are similar to previous changes (3)

packages/landing/src/components/Nav.tsx
packages/landing/vite/design-system-plugin.ts
packages/landing/vite.config.ts

📝 Walkthrough

Walkthrough

A new Vite plugin (designSystemPlugin) is added to packages/landing/vite/design-system-plugin.ts. It defines constants for light and dark design HTML file paths, emits both as build assets via generateBundle(), and registers dev-server middleware via configureServer() to serve them at /design-light.html and /design-dark.html. The plugin is registered in packages/landing/vite.config.ts alongside a new build-time __APP_VERSION__ constant sourced from the CLI package. The Nav component now calls useTheme(), memoizes a designLink as /design-${theme}, and points the desktop brand anchor to that URL. The generated HTML files are excluded from Biome formatting/linting (biome.json) and from Lefthook pre-commit checks (lefthook.yml).

🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (2 warnings, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request description is entirely empty—only the template structure with placeholder comments was provided, with no actual content in any of the Why, Details, or Verification sections.	Fill in the template sections: explain the motivation under Why, describe the approach and trade-offs under Details, and specify how the changes were tested under Verification.
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'Add in design theme' is vague and generic, using broad language that doesn't clearly convey the specific changes made to the codebase.	Replace with a more descriptive title that clearly explains the main change, such as 'Add design system theme support with light/dark HTML variants' or 'Create design theme routing and build plugin'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch julian/06-23-add_in_design_theme

_{Comment @coderabbitai help to get the list of available commands.}

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 62b62c47e8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

greptile-apps · 2026-06-23T19:20:22Z

Greptile Summary

This PR introduces light and dark variants of the design-system HTML page, wires the nav brand mark to link to the theme-appropriate file, bundles both files as static assets in production, and serves them via a new Vite dev-server middleware.

Design HTML split: design.html is renamed to design-dark.html and a new design-light.html is added; both are excluded from Biome linting and pre-commit hooks since they are auto-generated exports.
Plugin & config: A new designSystemPlugin emits the HTML files at build time and intercepts dev-server requests at /design-light.html and /design-dark.html; __APP_VERSION__ is also injected at build time from the CLI package.
Nav update: The desktop brand mark now dynamically resolves to /design-${theme} using the resolved 'light' | 'dark' value from useTheme().

Confidence Score: 5/5

Safe to merge; the changes are additive and well-scoped to the landing package.

The plugin logic is correct — each theme path is served from its own file with proper early returns. The __APP_VERSION__ global is already declared in vite-env.d.ts. The only finding is a stale JSDoc comment in Nav.tsx that still references the old #top link behavior.

No files require special attention.

Important Files Changed

Filename	Overview
packages/landing/src/components/Nav.tsx	Brand mark on desktop now dynamically links to the theme-specific design-system page; JSDoc comment retains the old `#top` description.
packages/landing/vite/design-system-plugin.ts	New Vite plugin that emits light/dark design HTML as static assets at build time and serves them via dev-server middleware; logic looks correct with proper early returns and distinct file paths per theme.
packages/landing/vite.config.ts	Registers the new `designSystemPlugin` and injects `__APP_VERSION__` from the CLI package; the global is already declared in `vite-env.d.ts`.
biome.json	Excludes `packages/landing/design*.html` from Biome linting to avoid false positives on auto-generated design-system HTML.
lefthook.yml	Mirrors the Biome exclusion in pre-commit hooks so design HTML files are skipped during both check and lint stages.

_{Reviews (4): Last reviewed commit: "Apply suggestions from code review" | Re-trigger Greptile}

coderabbitai

Actionable comments posted: 3

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fea96ab8-bc28-4f9d-a1de-8932410527b1

📥 Commits

Reviewing files that changed from the base of the PR and between b9a3f5b and 62b62c4.

📒 Files selected for processing (7)

biome.json
lefthook.yml
packages/landing/design-dark.html
packages/landing/design-light.html
packages/landing/src/components/Nav.tsx
packages/landing/vite.config.ts
packages/landing/vite/design-system-plugin.ts

eXamadeus · 2026-06-23T20:49:05Z

Merge activity

Jun 23, 8:49 PM UTC: A user started a stack merge that includes this pull request via Graphite.
Jun 23, 9:21 PM UTC: Graphite rebased this pull request as part of a merge.
Jun 23, 9:22 PM UTC: @eXamadeus merged this pull request with Graphite.

greptile-apps · 2026-06-23T20:51:45Z

Want your agent to iterate on Greptile's feedback? Try greploops.

coderabbitai · 2026-06-23T20:54:29Z

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details

{}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4822cae0ac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-23T21:23:27Z

 */
 export function Nav() {
  const isMobile = useIsMobile()
+  const [theme] = useTheme()


Keep the design link synced with theme toggles

In desktop sessions where the visitor uses the ThemeToggle, this separate useTheme() instance in Nav never observes the child component's local state update, so designLink keeps the theme resolved at the last Nav render. The page theme changes via the toggle's own hook, but the logo href can still point at the old /design-light or /design-dark route until a reload or OS preference event, sending users to the wrong themed design page.

Useful? React with 👍 / 👎.

Copilot AI review requested due to automatic review settings June 23, 2026 19:17

Copilot started reviewing on behalf of eXamadeus June 23, 2026 19:18 View session

Copilot AI reviewed Jun 23, 2026

chatgpt-codex-connector Bot reviewed Jun 23, 2026

View reviewed changes

Comment thread packages/landing/src/components/Nav.tsx

Comment thread packages/landing/vite/design-system-plugin.ts Outdated

Comment thread packages/landing/vite/design-system-plugin.ts

greptile-apps Bot reviewed Jun 23, 2026

View reviewed changes

Comment thread packages/landing/vite/design-system-plugin.ts

Comment thread packages/landing/vite/design-system-plugin.ts

Comment thread packages/landing/src/components/Nav.tsx

Comment thread packages/landing/src/components/Nav.tsx Outdated

coderabbitai Bot reviewed Jun 23, 2026

View reviewed changes

Comment thread packages/landing/src/components/Nav.tsx

Comment thread packages/landing/src/components/Nav.tsx Outdated

Comment thread packages/landing/vite/design-system-plugin.ts

eXamadeus changed the base branch from main to graphite-base/357 June 23, 2026 20:51

eXamadeus changed the base branch from graphite-base/357 to main June 23, 2026 20:51

eXamadeus changed the base branch from main to graphite-base/357 June 23, 2026 20:56

eXamadeus force-pushed the julian/06-23-add_in_design_theme branch from 9748a21 to 16a1fe0 Compare June 23, 2026 20:56

eXamadeus changed the base branch from graphite-base/357 to julian/06-23-regenerate_registry_api_snapshot_with_organizations_impersonation_migration_batches_private_facets_and_admin_event-health_endpoints June 23, 2026 20:56

eXamadeus mentioned this pull request Jun 23, 2026

Regenerate registry API snapshot with organizations, impersonation, migration batches, admin user search, and event health endpoints #358

Merged

Base automatically changed from julian/06-23-regenerate_registry_api_snapshot_with_organizations_impersonation_migration_batches_private_facets_and_admin_event-health_endpoints to main June 23, 2026 21:20

eXamadeus and others added 2 commits June 23, 2026 21:21

Add in design theme

f049f04

Apply suggestions from code review

4822cae

eXamadeus force-pushed the julian/06-23-add_in_design_theme branch from 16a1fe0 to 4822cae Compare June 23, 2026 21:21

eXamadeus merged commit 7193737 into main Jun 23, 2026
6 checks passed

eXamadeus deleted the julian/06-23-add_in_design_theme branch June 23, 2026 21:22

chatgpt-codex-connector Bot reviewed Jun 23, 2026

View reviewed changes

Uh oh!

Conversation

eXamadeus commented Jun 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why

Details

Verification

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

eXamadeus commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

❌ Failed checks (2 warnings, 1 inconclusive)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eXamadeus commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

greptile-apps Bot commented Jun 23, 2026

Uh oh!

coderabbitai Bot commented Jun 23, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

eXamadeus commented Jun 23, 2026 •

edited by coderabbitai Bot

Loading

changeset-bot Bot commented Jun 23, 2026 •

edited

Loading

eXamadeus commented Jun 23, 2026 •

edited

Loading

coderabbitai Bot commented Jun 23, 2026 •

edited

Loading

greptile-apps Bot commented Jun 23, 2026 •

edited

Loading

eXamadeus commented Jun 23, 2026 •

edited

Loading