Add ruff + pre-commit (format + E,F,I) — fixes #28

[kiranannadatha8]

Summary

• Adds [tool.ruff] config to pyproject.toml (line-length 99, py311, select E/F/I, excludes benchmarks + skyrl submodule)
• Pins ruff>=0.4,<0.5 and pre-commit>=3.6 in the dev extra
• New .pre-commit-config.yaml with ruff + ruff-format hooks pinned to v0.4.4
• Rewrites ## Style section in CONTRIBUTING.md with pre-commit install instructions
• Separate commit applies one-shot ruff format + --fix so the config change stays reviewable in isolation

Closes #28.

Test plan

• ruff check --select E,F,I clawloop tests examples exits 0
• ruff format --check clawloop tests examples exits 0
• Reviewer spot-checks commit 2 diff (genuinely-unused symbols removed: EvalResult, field, Future, OptimResult)
• pip install -e ".[dev]" && pre-commit install — hooks run on commit

Out of scope (deliberately, per issue)

• UP / B / SIM rules — semantic rewrites, deferred
• CI lint job — can be added in a follow-up
• Broader repository-wide pre-commit rollout — deferred

[gemini-code-assist]

Code Review

This pull request standardizes the codebase by adopting ruff for linting and formatting, adding pre-commit hooks, and updating contribution guidelines. The changes consist of extensive formatting adjustments across all modules and tests to ensure consistency. Feedback focuses on improving code quality by removing an empty TYPE_CHECKING block and several unused variables that were unnecessarily preserved with linter suppression tags.

[bordeauxred]

Thanks for picking this up. I refreshed the tracking issue as #28 and updated the PR metadata so this closes the live issue. The commits and contribution stay yours.

[kiranannadatha8]

Thanks for picking this up. I refreshed the tracking issue as #28 and updated the PR metadata so this closes the live issue. The commits and contribution stay yours.

Thanks for the swap to #28 — noted. Happy to follow up if anything else surfaces in review.

[bordeauxred]

Hi @kiranannadatha8,
thanks a lot for your contribution. Please adress the issues raised by gemini.

@tianyibigdata pleae also take a look

[tianyibigdata]

Thanks for picking this up. I refreshed the tracking issue as #28 and updated the PR metadata so this closes the live issue. The commits and contribution stay yours.

Thanks for the swap to #28 — noted. Happy to follow up if anything else surfaces in review.

Hey @kiranannadatha8, thank you for your contribution. Could you plz address the following issues:

1. Issues raised by Gemini Reivew
2. This integration into Github Workflow
3. Squash merge all commits into one

[kiranannadatha8]

Thanks for the review @bordeauxred @tianyibigdata. Status on the three items:

1. Gemini review comments — resolved in f080002:

• clawloop/environments/openclaw.py — dropped empty TYPE_CHECKING block + its import
• tests/test_curator_lightweight.py — removed unused report = binding; calling curator.consolidate(pb) directly
• tests/test_otel_exporter.py — removed unused original_span_kind / original_kind_agent assignments
• tests/test_local_evolver.py — removed unused playbook + dead import
• tests/test_harbor_env.py — removed unused env
• examples/openclaw_demo_remote.py — removed unused episodes: list[Episode] = []

No F841 noqa suppressions remain.

2. GitHub Workflow integration — added in 60f7e26. New parallel lint job in .github/workflows/ci.yml runs:

• ruff check --select E,F,I clawloop tests examples
• ruff format --check clawloop tests examples

Version lock chain: pre-commit pins v0.4.4 → pyproject.toml pins ruff>=0.4,<0.5 in [dev] → CI installs via pip install -e ".[dev]". Verified locally.

3. Squash merge — happy to either (a) leave the 4 commits and let you use GitHub's "Squash and merge" button, or (b) force-push a single squashed commit if you'd prefer the branch history clean before merge. LMK which you'd like.

[tianyibigdata]

Thanks for the review @bordeauxred @tianyibigdata. Status on the three items:

1. Gemini review comments — resolved in f080002:

• clawloop/environments/openclaw.py — dropped empty TYPE_CHECKING block + its import
• tests/test_curator_lightweight.py — removed unused report = binding; calling curator.consolidate(pb) directly
• tests/test_otel_exporter.py — removed unused original_span_kind / original_kind_agent assignments
• tests/test_local_evolver.py — removed unused playbook + dead import
• tests/test_harbor_env.py — removed unused env
• examples/openclaw_demo_remote.py — removed unused episodes: list[Episode] = []

No F841 noqa suppressions remain.

2. GitHub Workflow integration — added in 60f7e26. New parallel lint job in .github/workflows/ci.yml runs:

• ruff check --select E,F,I clawloop tests examples
• ruff format --check clawloop tests examples

Version lock chain: pre-commit pins v0.4.4 → pyproject.toml pins ruff>=0.4,<0.5 in [dev] → CI installs via pip install -e ".[dev]". Verified locally.

3. Squash merge — happy to either (a) leave the 4 commits and let you use GitHub's "Squash and merge" button, or (b) force-push a single squashed commit if you'd prefer the branch history clean before merge. LMK which you'd like.

thx, saw the gemini fix. one last thing, could you plz add the ruff and its flags to the precommit and call the following in the CI?

      - name: Run pre-commit hooks
        run: pre-commit run --all-files

plz force push the squahsed commit.

[kiranannadatha8]

Done, @tianyibigdata:

Pre-commit is now the source of truth. .pre-commit-config.yaml carries the flags:

- id: ruff
  args: [--fix, --select, "E,F,I"]
- id: ruff-format

CI lint job calls pre-commit directly:

- run: pip install -e ".[dev]"
- name: Run pre-commit hooks
  run: pre-commit run --all-files

No more duplicate flag config between ci.yml and the hook. Verified locally: pre-commit run --all-files → ruff Passed, ruff-format Passed.

Squashed — the 4 PR commits + the two follow-up fixes collapsed into a single commit 87005b8. Force-pushed with lease; PR branch is now one commit on top of main.

[kiranannadatha8]

Rebased onto latest main and resolved conflicts. Force-pushed as 3871ff9.

What moved in upstream main since fork:

• PR Move to uv and update no-key math demo  #43 (move to uv) — bumped requires-python>=3.12, test matrix 3.12/3.13
• PR feat: Tinker weight-tuning example + OpenSpiel RL env #44 (Tinker + OpenSpiel) — new clawloop/environments/openspiel.py, effective_episodes_per_iter in train.py, GRPO aggregation in loop.py
• PR Clean launch rough edges: artifacts optional imports docs extras smok… #45 (launch rough edges) — refactor of examples/demo_math.py into clawloop.demo_math

How I resolved:

1. pyproject.toml — kept both sides: dev extra now includes starlette/uvicorn/httpx (upstream) + ruff/pre-commit (mine); kept [tool.uv.sources] + [tool.ruff] side-by-side. Bumped target-version py311 → py312 to match the new >=3.12 baseline.
2. clawloop/core/loop.py, environments/__init__.py, train.py, examples/demo_math.py — took upstream content (newer refactors), re-applied ruff format + ruff check --fix --select E,F,I on top.
3. Added scripts/ to [tool.ruff].extend-exclude — matches the PR's scope (clawloop tests examples) and keeps pre-commit run --all-files green.

Lint violations surfaced by the new config (12 total, all fixed minimally):

• clawloop/core/loop.py: E501 (long comment moved above the field), E741 (renamed l → layer in a comprehension)
• clawloop/environments/openspiel.py: 2× E501 (split string literals)
• tests/unit/environments/test_openspiel.py: E501 (wrapped comment)
• tests/unit/weight_backends/test_tinker_{backend,exporter,sdk}.py: 7× E402 — added # noqa: E402 to imports that follow pytest.importorskip() (idiomatic; they literally can't be at top of file)

Verified locally:

• uvx ruff@0.4.4 check --select E,F,I clawloop tests examples → All checks passed!
• uvx ruff@0.4.4 format --check clawloop tests examples → 197 files already formatted
• pre-commit run --all-files → ruff Passed, ruff-format Passed

PR now shows 1 commit, MERGEABLE. Ready for re-review.

[tianyibigdata]

@kiranannadatha8 could you plz upgrade it to 3.12 cuz we switched the python to 312 and 313? We ran the CI but it failed for 3.11.

[kiranannadatha8]

@tianyibigdata bumped the lint job to Python 3.12 (was 3.11 — that was the CI fail). Also rebased onto latest main and re-ran the format + E,F,I fixes; pre-commit now passes clean.

Verified locally:

• uv run pre-commit run --all-files → both hooks pass
• uv run ruff check --select E,F,I clawloop tests examples → All checks passed
• uv run ruff format --check clawloop tests examples → 197 files already formatted

Single squashed commit, force-pushed with lease.

[tianyibigdata]

LGTM!