Restore the rate-limit guard alongside the toolchain upgrade - #88
Merged
Conversation
The guard PR and the toolchain PR were stacked; a rebase against the wrong base dropped the guard content when the toolchain change merged. Reinstate the canary test asserting the 60/min default bites on an undecorated route, the limiter-reset fixture, and the resolver constraints holding fastapi below 0.136 and starlette below 1.0 until a slowapi release fixes issue #281.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #86, whose content was dropped by a stacked-rebase mistake when #87 merged: the canary test (60 requests to /v1/armor succeed, the 61st must 429 — verified to fail on fastapi 0.140.7), the limiter-reset fixture, and the
fastapi<0.136/starlette<1.0constraints with the unpin condition (slowapi release containing the #282 fix). The merged lock already held fastapi 0.135.x, so production behavior was never at risk; this makes the hold and its canary explicit on main. 28/28 tests green.