chore(observability): remove temporary Sentry rate limiter - #80
Merged
Conversation
The pool-exhaustion storm from 2026-04-18 has subsided; restoring full fidelity of TooManyConnectionsError reports so future incidents are visible again. Closes #78
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 2026-04-18 pool-exhaustion storm has subsided. Removing the emergency
before_sendrate limiter that was added in #77 to protect Sentry quota, soTooManyConnectionsErrorevents are reported at full fidelity again and any future incidents are immediately visible.Changes
app/observability/sentry.py: remove_rate_limit_pool_exhaustion,_contains_pool_exhaustion, the_POOL_ERR_*constants, the_pool_err_times/_pool_err_lockstate, and thebefore_sendkwarg. Unusedtime/deque/Lock/asyncpg.exceptionsimports go with it.tests/test_sentry_rate_limit.py: removed (tested the code being reverted).Pool resilience changes in
app/database.py(pool_pre_ping,pool_recycle) are kept — those are general-purpose hardening, not a brake.Test plan
uv run ruff check .cleanuv run ruff format --check .cleanuv run pytest— 21/21 pass (7 fewer than before; the removed file accounts for them)Closes #78