refactor: move not-found to router default and add error boundary - #40
Merged
Merged
Conversation
Register the not-found component on the router via defaultNotFoundComponent instead of on the root route, so it covers errors thrown from the root route itself rather than being hosted inside the same route it protects. Add an ErrorBoundary component wired as defaultErrorComponent for the same reason — previously uncaught errors had no surface and rendered as a blank page.
✅ Deploy Preview for trove-web-production ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ErrorBoundarycomponent and register it on the router viadefaultErrorComponent. Previously uncaught errors in routes had no surface and rendered blank.defaultNotFoundComponentinstead of on the root route — same reason: a boundary on__root.tsxis hosted inside the same route it protects.error-boundary.tsxfollows the template's minimal pattern (no@/lib/loggerhere, so justconsole.error). Visual style is plain — does not include the existingnot-found.tsxAppLayout + Cardchrome. Worth a future pass if you want them visually paired or if you want the boundary to preserve the app shell.Test plan
pnpm dev— app boots normallypnpm buildandpnpm test:runboth pass