Fix squat YouTube embeds by releasing the oEmbed height attribute - #15
Merged
Conversation
Ghost's embed cards carry the fixed width/height attributes from the provider's oEmbed response. The existing rule set aspect-video and w-full on the iframe, but CSS aspect-ratio is ignored while the element has an explicit height — the attribute height acted as one, so embeds rendered as full-width strips ~113px tall. Adding h-auto lets aspect-video govern and embeds render at a proper 16:9.
✅ Deploy Preview for treepolitics-web ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
YouTube embeds in Ghost posts rendered as full-width strips ~113px tall instead of 16:9 players.
Root cause: Ghost's
kg-embed-cardHTML keeps the provider's oEmbedwidth/heightattributes on the iframe. Our.prose-ghost .kg-embed-card iframerule appliedaspect-video w-full, but CSSaspect-ratioonly applies while the height computes toauto— the iframe's height attribute acts as an explicit height (a UA presentational hint), so the ratio was silently ignored.Fix: add
h-autoto the rule so author CSS releases the attribute height andaspect-videogoverns.Testing