Finalize Phase D: sync docs + bump deploy actions off deprecated Node 20 - #16
Merged
Conversation
Auto-deploy (GitHub Actions + Workload Identity Federation) has been live since #15; update the docs that still described it as pending. - README: replace the "CI/CD tracked in #5" stub with a Continuous deployment section (WIF auth, runner-side docker build instead of Cloud Build, migrations not run in CI); label the manual deploy path a fallback. - deploy.sh: header now frames the script as the manual fallback rather than a stand-in until Phase D.
GitHub is deprecating the Node 20 action runtime; the deploy workflow emitted a deprecation warning on every run. Bump the three actions to the first major version that ships on Node 24: - actions/checkout v4 -> v5 - google-github-actions/auth v2 -> v3 - google-github-actions/setup-gcloud v2 -> v3 Verified each v* declares `runs.using: node24` and still exposes the inputs we pass (auth keeps workload_identity_provider + service_account; the other two take none from us). No workflow-logic change.
amrtgaber
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes out the Phase D / CI-CD work: auto-deploy (GitHub Actions + Workload Identity Federation) has been live since #15, so this syncs the docs to match and clears the runtime deprecation warning.
Docs
README.md— replaced theCI/CD … tracked in #5stub (a now-closed issue) with a Continuous deployment section: WIF auth (no stored keys), image built on the runner +docker push(not Cloud Build, and why), migrations not run in CI. Manualdeploy.shpath relabelled a fallback with a cross-link.scripts/deploy.sh— header reframed from "Until Phase D wires up auto-deploy…" to "auto-deploy is live; this is the manual fallback."CI
.github/workflows/deploy.yml— bump the three actions to their first Node-24 major (verified eachaction.ymldeclaresruns.using: node24and still accepts the inputs we pass):actions/checkoutv4 → v5google-github-actions/authv2 → v3google-github-actions/setup-gcloudv2 → v3No workflow-logic or app-behavior change. Merging triggers one auto-deploy that runs on the bumped actions — which doubles as the verification that they work and the Node-20 warning is gone.