Harden front end: stale-chunk reload, Sentry noise filtering, floating-promise guard - #31
Merged
Merged
Conversation
…romise - main.tsx: add a `vite:preloadError` listener that prompts a one-shot "new version available" toast (sonner) when a deploy replaces a chunk an open tab is importing. Prompt rather than force-reload — `defaultPreload: "intent"` fires the event on hover, and a forced reload would discard unsaved work. - lib/sentry.ts: add `beforeSend` + `ignoreErrors`/`denyUrls` to drop never-actionable noise (intentional AbortError cancellation, browser extensions, translating proxies, sandboxed storage) so it doesn't bury real errors or burn quota. - lib/auth.tsx: guard the fire-and-forget `checkAuth()` with `.catch` reporting to Sentry (it already catches internally; this prevents a future refactor from leaking an unhandled rejection).
✅ Deploy Preview for criticalbit-web ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30.
Applies the front-end production-hardening lessons from the aoe2-live-standings-api launch audit.
Changes
src/main.tsxadds avite:preloadErrorlistener that surfaces a one-shot "new version available" toast (sonner, already mounted in__root.tsx) with a Reload action. Prompt rather than force-reload: the router usesdefaultPreload: "intent", so the event fires on hover, and a forced reload would discard unsaved work.src/lib/sentry.tsaddsbeforeSend+ignoreErrors/denyUrlsto drop never-actionable noise (intentionalAbortErrorcancellation, browser extensions, translating proxies, sandboxed-storage errors) so it doesn't bury real errors or burn quota.src/lib/auth.tsxguards the fire-and-forgetcheckAuth()with a.catchthat reports to Sentry. It already catches internally; this prevents a future refactor from leaking an unhandled rejection.Test plan
pnpm lint— pass (pre-existing react-refresh warnings only)pnpm format:check— passpnpm tsc --noEmit— passpnpm test:run— 7 passedpnpm build— succeeds