chore(home): de-feature The King's Gauntlet now the tournament has ended - #29
Merged
Merged
Conversation
The King's Gauntlet now renders as a regular menu row alongside Vagrant Story — the marquee frame and pulse are gone — while the "Hosted by Hera" host credit stays as a stacked subtitle beneath the label. Split the bundled .crt-menu-row--featured rule into a layout-only --stacked modifier (column direction so the subtitle sits under the label line) and a decoration-only --featured modifier. --featured is now unused but kept for the next featured event; the two compose when an event also needs a subtitle.
✅ Deploy Preview for criticalbit-web ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The King's Gauntlet tournament has ended, so its home-page menu entry no longer needs the marquee treatment. It now renders as a regular row alongside Vagrant Story — no surrounding frame, no pulse animation — while the "Hosted by Hera" credit stays as a stacked subtitle beneath the label. The link target (
/kings-gauntlet) and[WATCH]tag are unchanged.CSS refactor
Split the bundled
.crt-menu-row--featuredrule along its two concerns so the featured treatment survives for reuse:.crt-menu-row--stacked(new) — layout only: column direction so.crt-menu-row__linecarries the label while a.crt-menu-subtitlesits beneath it. This is what the de-featured Gauntlet row now uses..crt-menu-row--featured(kept) — decoration only: the phosphor frame, tint, andcrt-featured-pulse. Currently unused but retained for the next featured event; it composes with--stackedwhen an event also needs a subtitle.Tests
--stackedand not--featured.pnpm lint,pnpm test:run, andpnpm buildall green.