fix(theme): readable light-mode primary, decoupled CRT glow - #27
Merged
Conversation
Light-mode --primary (icy blue, oklch 0.88 0.08 210) scored ~1.29:1 as text — unreadable, far below WCAG AA 4.5:1 — affecting every text-primary surface (links, wordmark, 404/Error headings, brand icon, link buttons). It conflated two roles: the always-bright CRT phosphor (screen is bg-black in both themes) and the semantic UI color that must read on light surfaces. - Add theme-independent --crt-primary (oklch 0.82 0.11 220); crt.css glow now references it, so the home page glows identically in both themes. - Retune light --primary to oklch 0.5 0.15 225 (#0071a2), same hue family, 4.95:1 on background; mirror to --ring and --chart-1. - Flip light --primary-foreground to near-white so bg-primary stays legible (white-on-primary 5.09:1).
✅ Deploy Preview for criticalbit-web ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The light-mode
--primary("icy blue",oklch(0.88 0.08 210)) was unreadable as text — about 1.29:1 against the light background, far below the WCAG AA 4.5:1 floor. It affected everytext-primarysurface: privacy/terms links, the.gg/BITwordmark, the 404 & Error headings, the brand icon, and thelinkbutton variant.Root cause
--primaryserved two conflicting roles:bg-blackin both themes.Darkening it for (2) would have muddied the signature CRT glow for (1).
Changes
--crt-primary: oklch(0.82 0.11 220). Allcrt.cssglow rules now reference it, so the home page glows identically in light and dark mode.--primary→oklch(0.5 0.15 225)(#0071a2) — same icy-blue hue family, now 4.95:1 on the background. Mirrored to--ringand--chart-1.--primary-foregroundto near-white sobg-primarybuttons, avatars, and text selection stay legible (white-on-primary 5.09:1).Contrast verified numerically (oklch → sRGB → WCAG) and visually in both themes; the CRT glow is unchanged.
Closes #25