Security: Unescaped User Input in CSS Selector (getIdFromUrl)#858
Merged
dmarcos merged 1 commit intoJul 2, 2026
Merged
Conversation
In assetsUtils.js, the `getIdFromUrl` function constructs a CSS selector using user-provided URL input with only single-quote escaping. This is vulnerable to CSS injection attacks. An attacker could craft a URL containing CSS metacharacters to break out of the attribute selector context, potentially leading to DOM-based XSS or information disclosure via CSS selectors. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
Contributor
|
I indeed modified in #853 the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Unescaped User Input in CSS Selector (getIdFromUrl)
Problem
Severity:
Medium| File:src/lib/assetsUtils.js:L10In assetsUtils.js, the
getIdFromUrlfunction constructs a CSS selector using user-provided URL input with only single-quote escaping. This is vulnerable to CSS injection attacks. An attacker could craft a URL containing CSS metacharacters to break out of the attribute selector context, potentially leading to DOM-based XSS or information disclosure via CSS selectors.Solution
Properly escape all CSS special characters in the URL before inserting into the selector, or better yet, avoid constructing selectors from user input. Use document.querySelectorAll and filter by attribute value in JavaScript instead.
Changes
src/lib/assetsUtils.js(modified)