This repository was archived by the owner on Jan 22, 2024. It is now read-only.
File formatting: client-example/main.go - #7
Open
laikee99 wants to merge 4 commits into
Open
Conversation
… when you don't want to change `client.config.Labels`. add: add a new method `LogfWithLabel`, etc to submit a logline without prefix such as `ERROR`, `INFO` etc.
afiskon
reviewed
Jun 14, 2022
| loki.Infof("source = %s, time = %s, i = %d\n", source_name, tstamp, i) | ||
| loki.Warnf("source = %s, time = %s, i = %d\n", source_name, tstamp, i) | ||
| loki.Errorf("source = %s, time = %s, i = %d\n", source_name, tstamp, i) | ||
| loki.LogfWithLabel("{source=\"new_"+source_name+"\"}", "source = %s, time = %s, i = %d\n", source_name, tstamp, i) |
Owner
There was a problem hiding this comment.
I believe this line shouldn't be in this patch.
afiskon
reviewed
Jun 14, 2022
| InfofWithLabel(label, format string, args ...interface{}) | ||
| WarnfWithLabel(label, format string, args ...interface{}) | ||
| ErrorfWithLabel(label, format string, args ...interface{}) | ||
| LogfWithLabel(label, format string, args ...interface{}) |
afiskon
suggested changes
Jun 14, 2022
afiskon
left a comment
afiskon
left a comment
Owner
There was a problem hiding this comment.
This patch doesn't simply change the code formatting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just format client-exmaple/main.go by
go-format.