fix: enforce literal path separator in coverage_exclude globs#1
Open
AACasado wants to merge 1 commit into
Open
fix: enforce literal path separator in coverage_exclude globs#1AACasado wants to merge 1 commit into
AACasado wants to merge 1 commit into
Conversation
glob::Pattern::matches() uses MatchOptions::default() where require_literal_separator is false, so '*' silently crosses '/' boundaries. A pattern like 'foo/*.java' was matching files in foo/bar/, foo/bar/baz/, etc., silently excluding entire subtrees. Introduces a glob_match_strict() helper used by all six coverage_exclude call sites (selector, exclusion counter, cleanup pass, retry pass, per-file safety net, and worktree parallel path). Reproduced on a Java repo where 'com/package/name/model/*.java' swallowed model/enums/, model/dto/, model/name/, leaving 0 candidates when ~56 were expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
glob::Pattern::matches() uses MatchOptions::default() where
require_literal_separator is false, so '' silently crosses '/'
boundaries. A pattern like 'foo/.java' was matching files in
foo/bar/, foo/bar/baz/, etc., silently excluding entire subtrees.
Introduces a glob_match_strict() helper used by all six coverage_exclude
call sites (selector, exclusion counter, cleanup pass, retry pass,
per-file safety net, and worktree parallel path).
Reproduced on a Java repo where 'com/package/name/model/*.java'
swallowed model/enums/, model/dto/, model/name/, leaving 0 candidates
when ~56 were expected.