[C#] refactor: seal PrimitiveValue and PrimitiveType, make ThrowHelper static - #1109
Merged
Merged
Conversation
Contributor
Author
|
@mikeb01 , SBE-dll package on nuget.org is published here https://www.nuget.org/packages/sbe-tool ? I am asking because it seems it's not updated since 2021? Project url is pointing to this repository. |
Contributor
|
Contributor
Author
Contributor
|
@trishagee Can you please help find the answer for the above question? |
|
I'm on it - I'll find out what the situation is and update this issue |
Contributor
Author
|
@trishagee opened issue so it's easier to track it #1113 |
|
Perfect, thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no reason
PrimitiveValueandPrimitiveTypeare not sealed. Practically they will be never inherited. Seal them, as JIT will skip MethodTable generation and should improve the performance by a small margin.