Skip to content

move fetch nav to eager scripts #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rrusher wants to merge 2 commits into
base: main
Choose a base branch
from
Open

move fetch nav to eager scripts #494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fefe5d8
move fetch nav to eager scripts
rrusher Oct 22, 2024
917491f
clean up
rrusher Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions blocks/header/header.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
fetchLangDatabyFileName,
} from '../../scripts/scripts.js';
import {
getLanguage, PATH_PREFIX, fetchLanguageNavigation,
getLanguage, PATH_PREFIX,
} from '../../scripts/utils.js';
import * as constants from './constants.js';
import {
Expand Down Expand Up @@ -426,7 +426,6 @@ export default async function decorate(block) {
: `${PATH_PREFIX}/${langCode}/nav`;
const fragment = await loadFragment(navPath);
const placeholdersData = await fetchLanguagePlaceholders();
fetchLanguageNavigation(`/${langCode}`);

// decorate nav DOM
block.textContent = '';
Expand Down
2 changes: 2 additions & 0 deletions scripts/scripts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import {
setPageLanguage,
cookiePopUp,
showCookieConsent,
fetchLanguageNavigation,
PATH_PREFIX,
} from './utils.js';

Expand Down Expand Up @@ -239,6 +240,7 @@ export async function load404() {
async function loadEager(doc) {
setPageLanguage();
decorateTemplateAndTheme();
fetchLanguageNavigation(`/${getLanguage()}`);

@mkbansal1 mkbansal1 Oct 23, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rrusher why It's important to call navigation in eager?

@thomsebastin thomsebastin Oct 23, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkbansal1 I believe by the time header loads, navigation items will be ready. Now, weather to load it in lazy vs eager might be debatable. If loading it in eager isn't impacting the score (which I think it isn't looking at the score), then I think it is fine.

await createSkipToMainNavigationBtn();
await cookiePopUp();
renderWBDataLayer();
Expand Down