fix(checkout): prevent duplicate order creation on double-click#714
Merged
Conversation
Move button disable + loading state to before any async work in the Chase credit card submit handler. Previously the button stayed enabled through address validation and estimate token refresh awaits, allowing a second click to trigger a concurrent createOrder call. All error/early-return paths now restore the button.
The pageshow handler already reset disabled and button text but did not remove the is-loading class, leaving the spinner visible when navigating back from the hosted payment page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move button disable + loading state to before any async work in the Chase credit card submit handler. Previously the button stayed enabled through address validation and estimate token refresh awaits, allowing a second click to trigger a concurrent createOrder call. All error/early-return paths now restore the button.
Test URLs: