Skip to content

Button variants #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashleyanness wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Button variants #674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9f7761
Enhance link button styles for sup and sub elements
ashleyanness Jul 8, 2026
2e9642e
Implement outline button styles
ashleyanness Jul 8, 2026
8fca12f
Fix indentation in conditional statement
ashleyanness Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions scripts/scripts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,6 +805,8 @@ function decorateButtons(main) {
a.className = 'button';
const strong = a.closest('strong');
const em = a.closest('em');
const hasSup = a.querySelector('sup') !== null;
const hasSub = a.querySelector('sub') !== null;
if (strong && em) {
a.classList.add('accent');
const outer = strong.contains(em) ? strong : em;
Expand All @@ -815,6 +817,14 @@ function decorateButtons(main) {
} else if (em) {
a.classList.add('link');
em.replaceWith(a);
} else if (hasSup) {
// superscript inside link, white outline button
a.classList.add('outline-white');
a.querySelector('sup').replaceWith(...a.querySelector('sup').childNodes);
} else if (hasSub) {
// subscript inside link, charcoal outline button
a.classList.add('outline-charcoal');
a.querySelector('sub').replaceWith(...a.querySelector('sub').childNodes);
}
p.className = 'button-wrapper';
}
Expand Down
31 changes: 31 additions & 0 deletions styles/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,6 +610,37 @@ button.button.close:focus {
background-color: var(--color-shadow);
}

a.button.outline-white,
button.button.outline-white {
border-color: var(--color-white);
background-color: transparent;
color: var(--color-white);
}

a.button.outline-white:hover,
button.button.outline-white:hover,
button.button.outline-white:focus {
border-color: var(--color-white);
background-color: rgb(255 255 255 / 15%);
color: var(--color-white);
}

a.button.outline-charcoal,
button.button.outline-charcoal {
border-color: var(--color-charcoal);
background-color: transparent;
color: var(--color-charcoal);
}

a.button.outline-charcoal:hover,
button.button.outline-charcoal:hover,
button.button.outline-charcoal:focus {
border-color: var(--color-charcoal);
background-color: rgb(0 0 0 / 8%);
color: var(--color-charcoal);
}


.default-content-wrapper .button.link {
text-align: left;
line-height: var(--line-height-xl);
Expand Down
Loading