Skip to content

Assesibility fix for the header [Do Not Merge] #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jindaliiita wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Assesibility fix for the header [Do Not Merge] #720

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b7baf4
assessibility fix
jindaliiita Jan 21, 2025
fb79ec9
Review comments fix
jindaliiita Jan 22, 2025
cdd0635
Merge remote-tracking branch 'origin/main' into a-fix
jindaliiita Jan 22, 2025
01ba772
Merge branch 'main' into a-fix
Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions blocks/header/nav.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,8 +410,8 @@ export default async function decorate(block) {
form({ class: 'search-form', action: `/${locale}/search`, method: 'get', autocomplete: 'off' },
label({ for: 'siteSearch' }, 'Search Query'),
input({ id: 'siteSearch', type: 'text', placeholder: 'Search', name: 'searchQuery', tabindex: '-1' }),
a({ class: 'search-button', type: 'submit', 'aria-label': 'Search' }),
a({ class: 'close', type: 'button', 'aria-label': 'Close' }),
a({ class: 'search-button', role: 'button', 'aria-label': 'Search' }),
a({ class: 'close', role: 'button', 'aria-label': 'Close' }),
),
),
);
Expand All @@ -421,7 +421,7 @@ export default async function decorate(block) {
navSearch.querySelector('a').setAttribute('aria-controls', 'nav-search-popup');
navSearch.querySelector('div').setAttribute('id', 'nav-search-popup');

const navLocate = div({ class: 'nav-locate', id: 'nav-locate', 'aria-expanded': false },
const navLocate = div({ class: 'nav-locate', id: 'nav-locate', 'aria-expanded': false, role: 'button' },
a({ href: '#', title: 'Find Your Service Center', 'aria-controls': 'nav-locate' }, 'Find Your Service Center'),
div({ class: 'locate-popup' },
span('Find Yours:'),
Expand Down