Skip to content

feat: portrait variant in columns #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fkakatie merged 2 commits into from
Jun 27, 2026
Merged

feat: portrait variant in columns #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b572f7
fix: rename narrow to portrait
fkakatie Jun 27, 2026
6217706
feat: portrait columns variant
fkakatie Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions blocks/columns/columns.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,3 +105,19 @@
grid-template-columns: 1fr 1fr;
}
}

/* portrait variant */
.columns.portrait .media-wrapper {
min-height: unset;
aspect-ratio: 2 / 3;
}

@media (width >= 600px) {
.columns.portrait [data-row="media"] {
display: flex;
}

.columns.portrait [data-row="media"] .media-wrapper {
max-width: 344px;
}
}
8 changes: 4 additions & 4 deletions tools/import/transform-page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,13 +462,13 @@ function gridWidth($el) {

// An image-multimedia paired with an adjacent sized text becomes a columns block:
// image side = DOM order (image-first -> left, text-first -> right)
// variant = equal widths -> regular columns; unequal -> columns (narrow)
// variant = equal widths -> regular columns; unequal -> columns (portrait)
function columnsPairBlock($img, $text, imgFirst, variant) {
const src = mediaImageSrc($img);
const alt = $img.find("img").first().attr("alt") || "";
const imgCell = `<div>${pic(src, alt)}</div>`;
const textCell = `<div>${cleanRte($text.find(".cmp-text").first()) || cleanRte($text)}</div>`;
const cls = variant === "narrow" ? "columns narrow" : "columns";
const cls = variant === "portrait" ? "columns portrait" : "columns";
const row = imgFirst ? `${imgCell}${textCell}` : `${textCell}${imgCell}`;
return `<div class="${cls}"><div>${row}</div></div>`;
}
Expand Down Expand Up @@ -671,14 +671,14 @@ for (let i = 0; i < raw.length; i++) {
// image first -> image on the left
if (next && next.type === "text" && gridWidth(next.$el) < 12 && !consumed.has(i + 1)) {
const wT = gridWidth(next.$el);
comps.push({ type: "columns-pair", $img: c.$el, $text: next.$el, imgFirst: true, variant: wImg === wT ? "regular" : "narrow", anchorId: c.anchorId });
comps.push({ type: "columns-pair", $img: c.$el, $text: next.$el, imgFirst: true, variant: wImg === wT ? "regular" : "portrait", anchorId: c.anchorId });
consumed.add(i + 1);
continue;
}
// text first -> image on the right (replace the already-pushed text)
if (prev && prev.type === "text" && gridWidth(prev.$el) < 12 && comps.length && comps[comps.length - 1] === prev) {
const wT = gridWidth(prev.$el);
comps[comps.length - 1] = { type: "columns-pair", $img: c.$el, $text: prev.$el, imgFirst: false, variant: wImg === wT ? "regular" : "narrow", anchorId: prev.anchorId };
comps[comps.length - 1] = { type: "columns-pair", $img: c.$el, $text: prev.$el, imgFirst: false, variant: wImg === wT ? "regular" : "portrait", anchorId: prev.anchorId };
continue;
}
}
Expand Down