Skip to content

break after 249 chars instead of after 34 words #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
helms-charity merged 1 commit into from
Apr 28, 2026
Merged

break after 249 chars instead of after 34 words #789

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions blocks/overview/overview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
const WORD_LIMIT = 34;

function splitWords(text) {
return text.trim().split(/\s+/).filter(Boolean);
}
const CHARACTER_LIMIT = 249;

export default function decorate(block) {
block.id = 'overview';
Expand All @@ -13,13 +9,12 @@ export default function decorate(block) {
if (heading) heading.classList.add('overview-title');
if (paragraphs[0]) paragraphs[0].classList.add('overview-para');

// Single paragraph: truncate to first WORD_LIMIT words with inline Read more / Read less
// Single paragraph: truncate after CHARACTER_LIMIT chars with inline Read more / Read less
if (paragraphs.length === 1 && paragraphs[0]) {
const p = paragraphs[0];
const words = splitWords(p.textContent);
if (words.length > WORD_LIMIT) {
const fullText = words.join(' ');
const truncatedText = words.slice(0, WORD_LIMIT).join(' ');
const fullText = p.textContent.trim();
if (fullText.length > CHARACTER_LIMIT) {
const truncatedText = fullText.slice(0, CHARACTER_LIMIT);
p.textContent = '';

const textSpan = document.createElement('span');
Expand Down
Loading