fix(tools/search): apply exclude paths filter in crawl-based HTML search#52
Open
ericvangeem wants to merge 1 commit into
Open
fix(tools/search): apply exclude paths filter in crawl-based HTML search#52ericvangeem wants to merge 1 commit into
ericvangeem wants to merge 1 commit into
Conversation
The exclude-paths check only existed in fetchFiles(), which is bypassed when the main HTML search uses DA's crawl() function. Added the same filter to the processItem callback so excluded paths are honored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Exclude Paths configuration field so it correctly skips paths during HTML content searches.
Problem
The exclude-paths check only existed inside
fetchFiles(), but the main HTML search bypassesfetchFiles()entirely — it uses DA'scrawl()function with aprocessItemcallback that never read theexclude-pathsinput. As a result, excluded paths were silently ignored.The JSON file search branch calls
fetchFilesForJson()directly and correctly honoured exclusions. Only the HTML crawl path was affected.Closes #51
Fix
Added the same exclude-paths guard from
fetchFiles()inside theprocessItemcallback, immediately after the.htmlextension check:Testing
/drafts)