Skip to content

chore: ux enhancements #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
usman-khalid merged 1 commit into from
Jun 10, 2026
Merged

chore: ux enhancements #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions tools/apps/da-permissions/da-permissions.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,26 @@ sl-button.pw-quiet-danger::part(base):hover:not(:disabled) {
transform: translateY(-50%) rotate(180deg);
}

.site-clear-btn {
position: absolute;
right: 0.4rem;
top: 50%;
transform: translateY(-50%);
display: flex;
align-items: center;
padding: 2px;
background: none;
border: none;
cursor: pointer;
color: var(--s2-gray-500);
border-radius: var(--s2-radius-75);
}

.site-clear-btn:hover {
color: var(--s2-gray-800);
background: var(--s2-gray-100);
}

.site-dropdown {
position: absolute;
top: calc(100% + 4px);
Expand Down
25 changes: 17 additions & 8 deletions tools/apps/da-permissions/da-permissions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,7 +612,11 @@ class DaPermissionsApp extends LitElement {
@keydown=${this.handleSiteInputKey}
@sl-blur=${this.handleSiteInputBlur}
></sl-input>
<span class="site-chevron ${this._siteDropdownOpen ? 'is-open' : ''}" aria-hidden="true">${icon('Smock_ChevronDown_18_N', 18, 18, '0 0 18 18')}</span>
${this._site && !this._siteDropdownOpen ? html`
<button class="site-clear-btn" aria-label="Clear site" @click=${() => this.navigateToOrg()}>${icon('S2_Icon_Close_20_N')}</button>
` : html`
<span class="site-chevron ${this._siteDropdownOpen ? 'is-open' : ''}" aria-hidden="true">${icon('Smock_ChevronDown_18_N', 18, 18, '0 0 18 18')}</span>
`}
${this._siteDropdownOpen ? html`
<div class="site-dropdown" role="listbox">
${this.filteredSites.map((site, i) => html`
Expand Down Expand Up @@ -802,6 +806,17 @@ class DaPermissionsApp extends LitElement {
`;
}

renderContextBar() {
if (this._state !== 'admin' || !this._site) return nothing;
return html`
<div class="context-back-bar">
<button class="context-back-btn" @click=${() => this.navigateToOrg()}>← ${this._org}</button>
<span class="context-sep">›</span>
<span class="context-site-label">${this._site}</span>
</div>
`;
}

// ---- Render: admin view ----

renderAdmin() {
Expand All @@ -810,13 +825,6 @@ class DaPermissionsApp extends LitElement {
${this._readOnly ? html`
<div class="message warning">You have read-only access to this configuration.</div>
` : nothing}
${this._site ? html`
<div class="context-back-bar">
<button class="context-back-btn" @click=${() => this.navigateToOrg()}>← ${this._org}</button>
<span class="context-sep">›</span>
<span class="context-site-label">${this._site}</span>
</div>
` : nothing}
<div class="slots-list">
${this.permissionSlots.map((slot) => this.renderSlot(slot, orgSectionTitles[slot.path] ?? null))}
${this._site && !this._newScopeOpen ? html`
Expand Down Expand Up @@ -882,6 +890,7 @@ class DaPermissionsApp extends LitElement {
render() {
return html`
${this.renderToolbar()}
${this.renderContextBar()}
${this.renderInfoPanel()}
${this.renderMessage()}
<div class="da-content">
Expand Down
Loading