Skip to content

DA Permissions App#48

Merged
usman-khalid merged 3 commits into
mainfrom
da-perms
Jun 9, 2026
Merged

DA Permissions App#48
usman-khalid merged 3 commits into
mainfrom
da-perms

Conversation

@usman-khalid

Copy link
Copy Markdown
Collaborator

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:

@aem-code-sync

aem-code-sync Bot commented Jun 8, 2026

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run all PSI checks
  • Re-run failed PSI checks
  • Re-sync branch
Commits

@usman-khalid usman-khalid changed the title Da perms DA Permissions App Jun 8, 2026
@usman-khalid
usman-khalid requested a review from dkuntze June 9, 2026 13:51
@amol-anand

Copy link
Copy Markdown
  1. In tools/apps/da-permissions/da-permissions.js:217-220, every non-write permission is treated as read. DA also supports an empty action for deny/none, so this can misrepresent locked-down content in the UI and removing that entry could accidentally widen access.

  2. In tools/apps/da-permissions/api.js:9-16 and tools/apps/da-permissions/da-permissions.js:289-302, any successful config fetch is treated as editable admin access. We should show that the user is in read-only mode and cannot make adjustments if they only have read access.

@usman-khalid
usman-khalid requested a review from amol-anand June 9, 2026 16:30
@usman-khalid

Copy link
Copy Markdown
Collaborator Author
  1. In tools/apps/da-permissions/da-permissions.js:217-220, every non-write permission is treated as read. DA also supports an empty action for deny/none, so this can misrepresent locked-down content in the UI and removing that entry could accidentally widen access.
  2. In tools/apps/da-permissions/api.js:9-16 and tools/apps/da-permissions/da-permissions.js:289-302, any successful config fetch is treated as editable admin access. We should show that the user is in read-only mode and cannot make adjustments if they only have read access.

Both fixed.

image image

@usman-khalid
usman-khalid merged commit fefdd1c into main Jun 9, 2026
1 of 2 checks passed
@usman-khalid
usman-khalid deleted the da-perms branch June 9, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants