Skip to content

Footer redesign js and css#68

Open
aaravind24 wants to merge 8 commits into
mainfrom
footer-redesign
Open

Footer redesign js and css#68
aaravind24 wants to merge 8 commits into
mainfrom
footer-redesign

Conversation

@aaravind24

@aaravind24 aaravind24 commented Apr 25, 2025

Copy link
Copy Markdown
Collaborator

@aem-code-sync

aem-code-sync Bot commented Apr 25, 2025

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync

aem-code-sync Bot commented Apr 25, 2025

Copy link
Copy Markdown
Page Scores Audits Google
📱 /group/drafts/asha/cob PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /group/drafts/asha/cob PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
aem-code-sync Bot temporarily deployed to footer-redesign April 28, 2025 06:21 Inactive
@rrusher

rrusher commented Apr 28, 2025

Copy link
Copy Markdown
Collaborator

Add the following to the .footer .footer-top-section::before selector in footer.css:

border-top-left-radius: 42px;
border-top-right-radius: 42px;

@aem-code-sync
aem-code-sync Bot temporarily deployed to footer-redesign April 29, 2025 05:19 Inactive
@aem-code-sync
aem-code-sync Bot temporarily deployed to footer-redesign April 29, 2025 05:21 Inactive
@aem-code-sync
aem-code-sync Bot temporarily deployed to footer-redesign April 29, 2025 12:16 Inactive
@aaravind24

Copy link
Copy Markdown
Collaborator Author

Add the following to the .footer .footer-top-section::before selector in footer.css:

border-top-left-radius: 42px;
border-top-right-radius: 42px;

@rrusher I've added a border radius to the footer now based on the page design that's now updated in figma. The border radius is present all 4 sides. I've updated accordingly.

@rrusher

rrusher commented Apr 29, 2025

Copy link
Copy Markdown
Collaborator
Screenshot 2025-04-29 at 1 24 43 PM

@aaravind24

Copy link
Copy Markdown
Collaborator Author

@rrusher updated

@rrusher
rrusher marked this pull request as ready for review April 30, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants