Nav c7#100
Merged
Merged
Conversation
Refactor text normalization and accessibility handling in header.js. Introduce cleanNavText function to improve text processing.
Added a function to extract dropdown child label and detail text from navigation items.
Removed logo configuration and related functions from header.js.
Removed the getDropdownChildData function and updated related code to directly extract label and href from child elements.
Added a function to extract dropdown child data including label and detail text.
Refactor logo handling and improve brand section parsing.
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
Resolved merge conflicts in the new header JS and CSS while preserving the navC7 updates, including external-link helper text cleanup, dropdown detail text, multi-state logo support, and updated multi-state logo sizing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the new EDS header navigation design from drafts/asha/header-nav-test2.
Changes Included:
Incorporated fixes identified during testing:
Validated functionality in the navc7 test branch prior to PR creation.
Test URLs: