Skip to content

Allow appending multiple items to a menu GH-68 #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
truthless-dev wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Allow appending multiple items to a menu GH-68 #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions consolemenu/console_menu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,17 +105,20 @@ def selected_item(self):
else:
return None

def append_item(self, item):
def append_item(self, *items):
"""
Add an item to the end of the menu before the exit item.
Add one or more items to the end of the menu before the exit item.

Args:
item (MenuItem): The item to be added.
items (list[MenuItem]): The item to be added.

"""
if len(items) == 0:
return
did_remove = self.remove_exit()
item.menu = self
self.items.append(item)
for item in items:
item.menu = self
self.items.append(item)
if did_remove:
self.add_exit()

Expand Down
12 changes: 12 additions & 0 deletions test/test_console_menu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,18 @@ def test_currently_active_menu(self):
menu2.join(timeout=5)
menu1.join(timeout=5)

def test_append_menu_items(self):
menu = ConsoleMenu("menu1", "test_currently_active_menu_1")
item1 = MenuItem(text='itemText', menu=menu)
item2 = MenuItem(text='itemText2', menu=menu)
item3 = MenuItem(text='itemText3', menu=menu)
menu.append_item()
menu.append_item(item1)
menu.append_item(item2, item3)
self.assertIn(item1, menu.items)
self.assertIn(item2, menu.items)
self.assertIn(item3, menu.items)

def test_remove_menu_item(self):
menu = ConsoleMenu("menu1", "test_currently_active_menu_1")
item1 = MenuItem(text='itemText', menu=menu)
Expand Down