Change Settings to "Make Web Request"#40
Open
techwithjake wants to merge 2 commits into
Open
Conversation
Add "TEXT" to "Content Type" Make "Variables to send" optional
Owner
|
Made variables optional. What should the content-type be? And how should I encode the body? |
Author
|
Still need to work on how to encode the body properly. Part of the reason I closed it out. I had set as just text/plain as the content type but no proper encoding. |
Back in line with CoRE master repo from ady624
Owner
|
I cannot merge this because it would not work. There is code that needs to handle the TEXT content-type (text/plain) and I need to know how "TEXT" would encode the body. Some ini-like maybe? param1=value1 with CRLF between the pairs? Or should it only be value1 with CRLF between the values, no parameter names? I am willing to add the requested feature though :) Let me know, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add "TEXT" to "Content Type"
Make "Variables to send" optional