Fix nested array-of-tables generating wrong source map paths#7
Open
thatch wants to merge 1 commit into
Open
Conversation
[[a.b]] and deeper nested AoTs were stored at /a/b/0 instead of /a/0/b/0 because _process_aot did not inject parent AoT indices. Two related fixes: - _process_aot: expand only the prefix segments (all but the last, which names the AoT being defined), so parent AoT indices are injected without the AoT injecting its own index into itself. - _expand_aot_segments: rewrite to walk segments left-to-right and insert an index after each segment that resolves to a known AoT pointer, instead of stopping after the first match. This correctly handles arbitrarily deep nesting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[[a.b]]and deeper nested AoTs were stored at/a/b/0instead of/a/0/b/0because_process_aotdid not inject parent AoT indices.Two related fixes:
_process_aot: expand only the prefix segments (all but the last, which names the AoT being defined), so parent AoT indices are injected without the AoT injecting its own index into itself._expand_aot_segments: rewrite to walk segments left-to-right and insert an index after each segment that resolves to a known AoT pointer, instead of stopping after the first match. This correctly handles arbitrarily deep nesting.