Write readme, increase test coverage#6
Merged
Merged
Conversation
thatch
commented
Mar 31, 2026
|
|
||
|
|
||
| def test_build_toml_aot(): | ||
| sm = build_source_map("[[items]]\nname = \"a\"\n[[items]]\nname = \"b\"\n", fmt="toml") |
Member
Author
There was a problem hiding this comment.
The multiline constants are a little silly, I'm on the fence about whether textwrap helps or not.,
nedbat
reviewed
Mar 31, 2026
| config = msgspec.convert(data, Config) | ||
| ``` | ||
|
|
||
| If `msgspec.convert` raises because `port` is a string instead of an integer, |
There was a problem hiding this comment.
I'd add this explanation above this:
ParseContext will intercept exceptions. If it can analyze them for precise locations, it will raise a
ParseErrorexception with the original exception as the cause. If it can't find location information, the original exception is raised as-is. No exceptions are swallowed.
nedbat
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.