Skip to content

Update update_times#19

Closed
MadPatrick wants to merge 0 commit into
adrighem:masterfrom
MadPatrick:master
Closed

Update update_times#19
MadPatrick wants to merge 0 commit into
adrighem:masterfrom
MadPatrick:master

Conversation

@MadPatrick

Copy link
Copy Markdown

Hi,

The update_times.json was not update correctly because is is pulled from repo.
Now with a local update check

Please check if this is workable

@adrighem

Copy link
Copy Markdown
Owner

Hmm, can you update your PR to only update the relevant parts. Right now, the diff replaces the whole file.

@adrighem

Copy link
Copy Markdown
Owner

Also, I've been implementing your requests from the forum thread, so the full file replace does not apply any more.

@MadPatrick

Copy link
Copy Markdown
Author

ok. wil check

@adrighem

Copy link
Copy Markdown
Owner

Thanks for the PR. The core idea makes sense: using the locally installed git repositories to derive update timing can be more reliable than depending only on the committed update_times.json.

I do not think we can accept this as-is yet. The diff is hard to review because plugin.py appears to have been regenerated with line-ending/whitespace churn, and the PR also conflicts with current master. It also deletes a couple of active update_times.json entries, and the runtime git work (fetch/log/status checks with long timeouts) needs to be kept narrow so opening the store or starting Domoticz cannot become slow.

Could you rebase on current master, keep generated/format-only changes out of the PR where possible, and limit the change to the update-time behavior? If the generated plugin.py must change, please regenerate it from plugin_core.py in the same format as the repo so the functional diff stays readable.

@MadPatrick

Copy link
Copy Markdown
Author

somehow i used version 2.4.0 and messed up the complete plugin.
I need to rework everything from start.
It is working on my test system, but no usable

@adrighem

adrighem commented Jun 14, 2026

Copy link
Copy Markdown
Owner

Probably because of th CRLF line endings. Let me take a look at it then...maybe I can refactor the old one into a workable diff.

@adrighem

Copy link
Copy Markdown
Owner

No, I'd have to create a separate branch and my own PR. Can you fix your PR yourself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants