feat(suggestions): filter suggestions by excludedPathPrefixes handler config (LLMO-6132)#2828
Open
dhavkuma wants to merge 1 commit into
Open
feat(suggestions): filter suggestions by excludedPathPrefixes handler config (LLMO-6132)#2828dhavkuma wants to merge 1 commit into
dhavkuma wants to merge 1 commit into
Conversation
… config Hide suggestions whose URL matches excluded path prefixes defined in the site handler config. Applied after grant-status filter in all 4 suggestion read variants. Fixes subpath-sibling URL leak (LLMO-6132). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This PR will trigger a minor release when merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filterByExcludedPaths(suggestions, opportunity, siteConfig)helper insrc/controllers/suggestions.jsfilterByGrantStatusin all 4 suggestion read variants:getAllForOpportunity,getAllForOpportunityPaged,getByStatus,getByStatusPagedgetSuggestionUrlhelper to extract URL across all opportunity typesexcludedPathPrefixesfromsiteConfig.getHandlerConfig(opportunity.getType())Hides suggestions for subpath-sibling URLs (e.g.
/jp/ja/...for PwC Japan) from API responses — including suggestions already stored in the DB before the audit-worker fix ships.Depends on: adobe/spacecat-shared#1817
Jira: LLMO-6132
Test plan
🤖 Generated with Claude Code