chore(aso-overlay): document ASO_OVERLAY_API_KEY_PREVIOUS in .env.example#2797
Closed
abhishekgarg18 wants to merge 1 commit into
Closed
Conversation
…mple Non-blocking follow-up from Alina's review of PR adobe#2663 (dual-key overlap for API key rotation): the handler already accepts ASO_OVERLAY_API_KEY_PREVIOUS as the previous-key fallback, but the env var was undocumented in the example file, so local devs had no signal it exists. Empty in steady state; operators populate it during a rotation window (populating both aso_keys_previous at Fastly and ASO_OVERLAY_API_KEY_PREVIOUS here in lockstep — see spacecat-infrastructure#627 MIGRATION-lite-e.md for the rotation flow) so dispatcher pods still holding the old key are not 401'd during EVO propagation. Co-Authored-By: Claude <noreply@anthropic.com>
miakobchuk
approved these changes
Jul 13, 2026
4 tasks
Member
Author
|
Superseded by #2834 (re-opened from internal branch so full CI runs). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ASO_OVERLAY_API_KEY_PREVIOUS=(empty) to.env.examplefordiscoverability + local parity, so devs know the previous-key fallback
env var exists without having to grep the auth handler.
(empty in steady state; populated in lockstep with
aso_keys_previouson the Fastly edge during rotation — see spacecat-infrastructure#627
MIGRATION-lite-e.md).Background
Non-blocking follow-up from @alinarublea's approving review on the
already-merged #2663 (dual-key overlap for API key rotation, ADR I13):
Test plan
.env.examplestill parseable — no code changes, pure docs/config example.shipped in feat(aso-overlay): dual-key overlap for API key rotation (ADR I13) #2663).
🤖 Generated with Claude Code