Fix assorted bugs, descriptions, and output issues#69
Merged
telegrapher merged 1 commit intoFeb 27, 2026
Conversation
- Make decode output a single parseable JSON object with header/payload - Fix fmt.Printf writing error to stdout instead of stderr (log.Printf) - Fix wrong flow description in authz service command - Add trailing newline in refresh fullOutput mode - Fix grammar "an user" to "a user" in profile command - Declare --organization/--userID mutual exclusion via cobra - Fix doc comment "access token" to "service token" in admin profile - Fix "decodification" to "decoding" in decode error message
andresbott
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Decode output is now valid JSON (
cmd/decode.go). Previously printed header and payload as two separate JSON objects. Now outputs a single{"header":...,"payload":...}object.Fix stdout corruption (
ims/profile.go:120).fmt.Printfwrote error to stdout, corrupting JSON output for piped commands. Changed tolog.Printfwhich writes to stderr.Fix wrong flow description (
cmd/authz/service.go:24). Said "Client Credential Authorization Flow" but the code exchanges an authorization code. Fixed to "Authorization Code Exchange". Also removed mismatched trailing quote.Add trailing newline in refresh fullOutput (
cmd/refresh.go:44).fmt.Printf("%s", jsonData)had no newline, causing the shell prompt to appear on the same line.Fix grammar (
cmd/profile.go:25). "an user" → "a user".Declare mutual exclusion (
cmd/exchange.go:50).--organizationand--userIDare now declared viacmd.MarkFlagsMutuallyExclusive()for better help output and CLI-level validation.Fix doc comment (
ims/admin_profile.go:45). Said "access token" but the function uses a service token.Fix typo (
ims/decode.go:36). "decodification" → "decoding".Note: Stacked on #68 (
refactor/pretty-json-package). Once #68 merges, GitHub retargets this PR tomain.