Deduplicate token resolution and use pretty-print in admin commands#65
Merged
Merged
Conversation
Extract shared resolveToken() helper into config.go to replace duplicate switch blocks in validate.go and invalidate.go. Use output.PrintPrettyJSON in admin profile and organizations commands for consistent JSON output.
andresbott
approved these changes
Feb 26, 2026
telegrapher
deleted the
refactor/dedup-token-resolve-and-pretty-print
branch
February 28, 2026 13:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract shared
resolveToken()helper intoims/config.go. The switch statement mapping Config token fields toims.TokenTypevalues was duplicated betweenims/validate.goandims/invalidate.go. The new helper covers all 5 token types (AccessToken, RefreshToken, DeviceToken, ServiceToken, AuthorizationCode) and both callers now use it.Use
output.PrintPrettyJSONin admin commands.cmd/admin/profile.goandcmd/admin/organizations.goused rawfmt.Println(resp)while all other commands that output JSON usedoutput.PrintPrettyJSON. This makes the output consistent across the CLI.