Skip to content

fix: use new route#408

Merged
tripodsan merged 1 commit into
mainfrom
use-helix3-byocdn
Jul 23, 2026
Merged

fix: use new route#408
tripodsan merged 1 commit into
mainfrom
use-helix3-byocdn

Conversation

@tripodsan

Copy link
Copy Markdown
Contributor

Use admin route for BYOCDN push invalidation service

Test URLs:

@aem-code-sync

aem-code-sync Bot commented Jul 23, 2026

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run all PSI checks
  • Re-run failed PSI checks
  • Re-sync branch
Commits

@aem-code-sync

aem-code-sync Bot commented Jul 23, 2026

Copy link
Copy Markdown
Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@tripodsan
tripodsan merged commit 7d69c98 into main Jul 23, 2026
4 of 5 checks passed
@tripodsan
tripodsan deleted the use-helix3-byocdn branch July 23, 2026 12:19
@claude

claude Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Code Review

Reviewed the two changed files (tools/cdn-check/cdn-check.js, tools/cdn-setup/cdn-setup.js). The change swaps the BYOCDN push-invalidation endpoint from https://helix-pages.anywhere.run/helix-services/byocdn-push-invalidation/v1 to https://admin.hlx.page/hook/byocdn-push-invalidation/ in both call sites.

Checks performed

  • Confirmed both usages (checkPurge in cdn-check.js, validateCdnConfig in cdn-setup.js) only change the URL constant — the fetch call shape (POST, application/x-www-form-urlencoded, form field names) is unchanged, so the new endpoint should be a drop-in replacement.
  • Searched the repo for any other reference to the old helix-pages.anywhere.run URL — none found, so the migration is complete across the codebase.
  • Both changed lines are well under the 100-char line-length limit; no other style issues.
  • PR description includes before/after preview URLs as required.

Issues Found

None (BLOCKING / SHOULD FIX / CONSIDER).

Verdict

APPROVE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant