fix: update versions test to handle multiple audit groups after #931#938
Closed
chrischrischris wants to merge 1 commit into
Closed
fix: update versions test to handle multiple audit groups after #931#938chrischrischris wants to merge 1 commit into
chrischrischris wants to merge 1 commit into
Conversation
PR #931 changed formatVersions to keep audit entries in separate groups when split by a labeled version boundary. The test now finds two .is-audit elements (one before and one after 'ver 1'), causing a strict mode violation. Use .first() to target the most recent audit group. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
Commits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatVersionsinhelpers.jsto keep audit entry groups separate when a labeled version boundary falls between them.test/e2e/tests/versions.spec.jswas using a strict-mode locator (.da-version-entry.is-audit) that expected exactly one match, but the test scenario now produces two.is-auditentries — one for edits before "ver 1" and one for edits after..first()to select the most recent audit group (the post-"ver 1" edits), which is what the test intends to verify.Test plan