fix: add fallback for path sanitization logic#936
Merged
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
Commits
|
chrissmillar
approved these changes
May 13, 2026
auniverseaway
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #928 rewrote aem.page/aem.live library URLs to content.da.live, which 404s for sources that genuinely live on the AEM host and were never copied to DA. This adds a 404-only fallback so mixed libraries work again.
daFetchLibrary wrapper: rewritten URL first, original on 404 only (auth/5xx still surface). Used by getItems, getBlocks, handleTemplateClick.
getBlockVariants does the same fallback inline (it can't share the wrapper because of the .plain.html suffix). fetchAndParseHtml now returns { doc, notFound } so 404 is distinguishable.
Tested against milo (library on sharepoint) and on client that has locked aem.page library