Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a part of the fix for wrongly encoded files in R2:
During the bucket migration (from @auniverseaway to Franklin-dev) and for an unknown reason (wrong cache headers ?), some documents got wrongly encoded in the destination bucket - documents are gzip encoded with the source content type.
This cause a weird issue: not sure what happens in production, but when running locally, the worker hangs forever when reading the S3 client response body and is then completely unreachable - it has to be reloaded. I assume in prod, the request just times out. Consequence: empty page in authoring and content is never written to the file.
This PR addresses the GET problem. But it is not enough because the write crashes then (
Failed to update document Error: 411 - Length Requiredin da-collab). Probably a similar trick could be found.But I will not investigate further. I'll just make a console.warn to detect the corrupted documents and from time to time, run a script to clean up the few remaining corrupted files (script here: https://github.com/kptdobe/da-magic/blob/main/encoding/fix-s3-document-encoding.sh).